Conversation
NYU IT is migrating API auth from WSO2 to Microsoft Entra ID. Add a dual-mode token path in nyuApiAuth: default keeps the WSO2 password grant; NYU_API_AUTH_PROVIDER=entra switches to the Entra client_credentials grant. Deploy workflows pass through the new provider flag and Entra client id/secret. Default behavior is unchanged until the flag is set.
feat(auth): add Entra ID client_credentials token mode for NYU API
Tenant Schema Diff (development → production)This PR targets Key Differences by DocumentFull dry-run output |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Ships #1502 (Entra ID
client_credentialstoken mode for the NYU API) to production. This is the only change betweenprodandmain.Why now: NYU IT migrated
identity-v2-systo Entra ID during the July 8 migration window (3–5pm EDT). The API gateway now rejects WSO2 tokens with400 "Token format is not valid.", so production identity fetches have been failing on cache misses since 4:33pm EDT on July 8 (first affected users: efh257, jyl9645, nw2289). The 7-day Firestore identity cache is absorbing most of the impact, but coverage shrinks daily as entries expire.Configuration is already in place (verified against the live API):
NYU_ENTRA_CLIENT_ID/NYU_ENTRA_CLIENT_SECRETare set.NYU_API_AUTH_PROVIDER=entrais set, so this deploy switches token acquisition to Entra.MuleSoft_Booking App_EID) access toidentity-v2-syson July 8: a live Entra token now returns200with real identity data (401/403before the grant). Theapi_access_idquery parameter is still required post-migration and the code already sends it.NYU_API_AUTH_PROVIDERis unset, but WSO2 tokens are permanently rejected by the API, so the flag flip is what restores service.Schema Changes
Checklist
Screenshots / Video
Backend-only change (NYU token endpoint); no UI. Verification against the live NYU API is described above; unit tests for both provider paths are in
tests/unit/nyuApiAuth.unit.test.ts(see #1502).